Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a file for storing all constants #21

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Created a file for storing all constants #21

merged 8 commits into from
Apr 24, 2024

Conversation

dikgarg
Copy link
Collaborator

@dikgarg dikgarg commented Apr 17, 2024

I created a constants.py file which stores all the constants that are used throughout the nupyprop code.

@dikgarg dikgarg requested a review from LuKupari April 17, 2024 20:44
@dikgarg dikgarg self-assigned this Apr 17, 2024
lkupari
lkupari approved these changes Apr 22, 2024
View reviewed changes
Copy link

@lkupari lkupari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have nothing to add.

I'll have to add these to the new geometry module!

@dikgarg dikgarg merged commit 18cc241 into main Apr 24, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkupari lkupari lkupari approved these changes

@LuKupari LuKupari LuKupari approved these changes

Assignees

@dikgarg dikgarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dikgarg @lkupari @LuKupari